From 0d005b526ed554a165a83557512e745c8de335d6 Mon Sep 17 00:00:00 2001 From: Ben Harris Date: Thu, 22 Jun 2023 23:34:48 +0100 Subject: [PATCH] Pearl: slightly better handling of clicks outside the grid In Pearl, a mouse-down outside the grid sets ui->ndragcoords to -1. The intended effect of this is to make sure that future drags are ignored, so you can't try to draw a line starting off the grid. However, this also has the effect of clearing any in-progress drag. This can happen if there's a keyboard "drag" in progress at the time. This is arguably wrong, but much more wrong was that interpret_move returned MOVE_UNUSED (and previously NULL) in this case. That meant that the display didn't get updated to show the abandonment of the drag, or the removal of the keyboard cursor that also happened. This commit changes MOVE_UNUSED to MOVE_UI_UPDATE so that at least the effect is correctly visible. --- pearl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pearl.c b/pearl.c index 34abf2a..402273f 100644 --- a/pearl.c +++ b/pearl.c @@ -2175,7 +2175,7 @@ static char *interpret_move(const game_state *state, game_ui *ui, if (!INGRID(state, gx, gy)) { ui->ndragcoords = -1; - return MOVE_UNUSED; + return MOVE_UI_UPDATE; } ui->clickx = x; ui->clicky = y;