From 101324af67c5e7819849daeafb337dd4c1f45828 Mon Sep 17 00:00:00 2001 From: Simon Tatham Date: Thu, 30 Jun 2005 08:25:47 +0000 Subject: [PATCH] Attempting to begin a drag from (i.e. just click on) the hint pegs for a past guess caused strangeness up to and including segfault, thanks to bad bounds checking. Well spotted John Sullivan. [originally from svn r6040] --- guess.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guess.c b/guess.c index bf7a148..12d8b1b 100644 --- a/guess.c +++ b/guess.c @@ -637,7 +637,7 @@ static char *interpret_move(game_state *from, game_ui *ui, game_drawstate *ds, } else { over_hint = 1; } - } else if (x >= guess_ox && + } else if (x >= guess_ox && x <= (guess_ox + GUESS_W) && y >= GUESS_OY && y < guess_oy) { over_past_guess_y = (y - GUESS_OY) / PEGOFF; over_past_guess_x = (x - guess_ox) / PEGOFF;