From 1880feb442c4b2d73137b02c8dc58f8d38f4e16a Mon Sep 17 00:00:00 2001 From: Ben Harris Date: Mon, 20 Feb 2023 00:28:42 +0000 Subject: [PATCH] Support multiple COMPILE_DEFINITIONS for a program Despite the name, COMPILE_DEFINITIONS was only ever used to set a single definition, and as far as I can tell that's all it could do even when I tried to put them in a single word separated by semicolons. Turning COMPILE_DEFINITIONS into a multi-valued argument seems to make it work much better. --- cmake/setup.cmake | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmake/setup.cmake b/cmake/setup.cmake index ea8d1bf..4008030 100644 --- a/cmake/setup.cmake +++ b/cmake/setup.cmake @@ -115,7 +115,7 @@ endfunction() # a command-line helper tool. function(cliprogram NAME) cmake_parse_arguments(OPT - "" "COMPILE_DEFINITIONS" "" ${ARGN}) + "" "" "COMPILE_DEFINITIONS" ${ARGN}) if(build_cli_programs) add_executable(${NAME} ${CMAKE_SOURCE_DIR}/nullfe.c @@ -131,7 +131,7 @@ endfunction() # the normal puzzle frontend. function(guiprogram NAME) cmake_parse_arguments(OPT - "" "COMPILE_DEFINITIONS" "" ${ARGN}) + "" "" "COMPILE_DEFINITIONS" ${ARGN}) if(build_gui_programs) get_platform_puzzle_extra_source_files(extra_files ${NAME})