From 20d424bf1bef4c1ed249ec3c72a859deb926e207 Mon Sep 17 00:00:00 2001 From: Simon Tatham Date: Mon, 24 Apr 2023 14:24:19 +0100 Subject: [PATCH] Emscripten: change the localStorage key used for preferences. I picked pathname + "#preferences" because Ben suggested either that or pathname + "/preferences", and I thought the former sounded neater. But Ben now suggests that it might be better to avoid using # in the key, just in case anyone should later want to use the whole URL _including_ the fragment ID as the key for some other localStorage usage - for example, autosaved progress per puzzle _instance_, keying off the puzzle URL with a fragment ID in the game description. So, per Ben's replacement suggestion, change the "#" to a space. --- emcclib.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/emcclib.js b/emcclib.js index d161c49..8dd1554 100644 --- a/emcclib.js +++ b/emcclib.js @@ -801,7 +801,7 @@ mergeInto(LibraryManager.library, { */ js_save_prefs: function(buf) { var prefsdata = UTF8ToString(buf); - localStorage.setItem(location.pathname + "#preferences", prefsdata); + localStorage.setItem(location.pathname + " preferences", prefsdata); }, /* @@ -811,7 +811,7 @@ mergeInto(LibraryManager.library, { * pass it back in as a string, via prefs_load_callback. */ js_load_prefs: function(me) { - var prefsdata = localStorage.getItem(location.pathname+"#preferences"); + var prefsdata = localStorage.getItem(location.pathname+" preferences"); if (prefsdata !== undefined && prefsdata !== null) { prefs_load_callback(me, prefsdata); }