zakarya/puzzles
1
0
Fork 0
mirror of git://git.tartarus.org/simon/puzzles.git synced 2025-04-20 23:51:29 -07:00
Code Issues Packages Projects Releases Wiki Activity

Last-ditch maximum size limit for Flip

Browse Source 
This makes sure that width * height <= INT_MAX, which it rather needs
to be.  Also in Flip's case that the square of the area still fits in
an int.
This commit is contained in:
Ben Harris
2023-01-10 11:07:14 +00:00
parent 522588f699
commit 26d0633f87
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
flip.c
View File

@ -8,6 +8,7 @@
#include <string.h>
#include <assert.h>
#include <ctype.h>
#include <limits.h>
#include <math.h>
#include "puzzles.h"
@ -181,9 +182,16 @@ static game_params *custom_params(const config_item *cfg)
static const char *validate_params(const game_params *params, bool full)
{
int wh;
if (params->w <= 0 || params->h <= 0)
return "Width and height must both be greater than zero";
return NULL;
if (params->w > (INT_MAX - 3) / params->h)
return "Width times height must not be unreasonably large";
wh = params->w * params->h;
if (wh > (INT_MAX - 3) / wh)
return "Width times height is too large";
return NULL;
}
static char *encode_bitmap(unsigned char *bmp, int len)