zakarya/puzzles
1
0
Fork 0
mirror of git://git.tartarus.org/simon/puzzles.git synced 2025-04-20 23:51:29 -07:00
Code Issues Packages Projects Releases Wiki Activity

Fix a memory management bug in Filling: in some situations its

Browse Source 
solve_game() was returning its aux parameter un-dupstr()ed, which is
wrong. Also clarified the developer docs on that function to make it
clearer that the returned string should be dynamic.

[originally from svn r9831]
This commit is contained in:
Simon Tatham
2013-04-13 10:37:27 +00:00
parent 0b93de904a
commit 339329449f
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
devel.but
View File

@ -1020,9 +1020,11 @@ it may return \cw{NULL}. If it does this, it must also set
\q{Solution not known for this puzzle}); that error message is not \q{Solution not known for this puzzle}); that error message is not
expected to be dynamically allocated. expected to be dynamically allocated.
If this function \e{does} produce a solution, it returns a move If this function \e{does} produce a solution, it returns a move string
string suitable for feeding to \cw{execute_move()} suitable for feeding to \cw{execute_move()}
(\k{backend-execute-move}). (\k{backend-execute-move}). Like a (non-empty) string returned from
\cw{interpret_move()}, the returned string should be dynamically
allocated.
\H{backend-drawing} Drawing the game graphics \H{backend-drawing} Drawing the game graphics

2
filling.c
View File

@ -975,7 +975,7 @@ static char *solve_game(game_state *state, game_state *currstate,
if (!solver(state->board, w, h, &aux)) if (!solver(state->board, w, h, &aux))
*error = "Sorry, I couldn't find a solution"; *error = "Sorry, I couldn't find a solution";
} }
return aux; return dupstr(aux);
} }
/***************************************************************************** /*****************************************************************************