js: Load save files into the C side incrementally

Before this commit, JavaScript Puzzles loaded a save file by pushing the
entire file onto the Emscripten stack and then reading it from there.
This worked tolerably for typical save files, but Emscripten's stack
defaults to only having 64 kiB of space.  That meant that trying to load
something that wasn't a real save file tended to cause a stack overflow.
I expect that at least some real save files would suffer from the same
problem.

The stack overflow would generally cause a JavaScript exception and then
leave the stack pointer outside the stack, so that any future attempt to
call into C would fail as well.

To fix this, arrange that the C function for reading data from the save
file calls out to JavaScript.  The JavaScript can then copy just the
requested data into the caller's buffer.  We can't pass a JavaScript
function pointer to C, but since only one file can be loaded at a time,
we can just have a global variable that's the current loading callback.

There might still be a problem if you try to load a stupendously large
file, since I think FileReader.readAsArrayBuffer() reads the whole file
into the browser's RAM.  It works on my laptop with files up to a few
hundred megabytes, though.
This commit is contained in:
Ben Harris
2023-04-03 15:16:35 +01:00
parent 8d3a93ce47
commit 36c282aaa9
3 changed files with 37 additions and 16 deletions

View File

@ -783,5 +783,14 @@ mergeInto(LibraryManager.library, {
*/
js_focus_canvas: function() {
onscreen_canvas.focus();
},
/*
* bool js_savefile_read(void *buf, int len);
*
* Read len bytes from the save file that we're currently loading.
*/
js_savefile_read: function(buf, len) {
return savefile_read_callback(buf, len);
}
});