zakarya/puzzles
1
0
Fork 0
mirror of git://git.tartarus.org/simon/puzzles.git synced 2025-04-21 16:05:44 -07:00
Code Issues Packages Projects Releases Wiki Activity

Fix error highlighting of closed subgraphs in Bridges.

Browse Source 
When I did the recent rewrite of the Bridges drawing code, I spotted
and replicated the code in game_redraw that set G_WARN at redraw time
on an island with unsatisfiable clues, but didn't spot the code
elsewhere (e.g. map_group_check) which might have set G_WARN ahead of
time, so I failed to check for that. As a result, if you join some
islands together into a subgraph with no further room for expansion
(e.g. connect a pair of 1s together, or a pair of 2s with a double
bridge) then all the bridges in that subgraph light up red but the
islands themselves forget to.

Trivial one-line fix.
This commit is contained in:
Simon Tatham
2014-10-29 21:41:38 +00:00
parent 3017455259
commit 4a8edc65bb
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
bridges.c
View File

@ -2967,7 +2967,7 @@ static void game_redraw(drawing *dr, game_drawstate *ds,
if (is_drag_src && (is == is_drag_src || if (is_drag_src && (is == is_drag_src ||
(is_drag_dst && is == is_drag_dst))) (is_drag_dst && is == is_drag_dst)))
idata |= DI_COL_SELECTED; idata |= DI_COL_SELECTED;
else if (island_impossible(is, v & G_MARK)) else if (island_impossible(is, v & G_MARK) || (v & G_WARN))
idata |= DI_COL_WARNING; idata |= DI_COL_WARNING;
else else
idata |= DI_COL_NORMAL; idata |= DI_COL_NORMAL;