From 742cf3a4434e65e1b83ca4d5510d329703665839 Mon Sep 17 00:00:00 2001 From: Simon Tatham Date: Sun, 31 Mar 2013 18:36:03 +0000 Subject: [PATCH] A UI suggestion from Ben: label the Custom element in the dropdown with a trailing "..." to hint that it opens a further dialog box. However, the _invisible_ Custom option is merely indicating what you _do_ have selected, so we leave that one as it is. (So now they're no longer exact twins of each other, of course.) [originally from svn r9796] --- emcclib.js | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/emcclib.js b/emcclib.js index b4c5813..6c37c9b 100644 --- a/emcclib.js +++ b/emcclib.js @@ -67,7 +67,7 @@ mergeInto(LibraryManager.library, { * case we need to do something special - see below. */ js_add_preset: function(ptr) { - var name = (ptr == 0 ? "Custom" : Pointer_stringify(ptr)); + var name = (ptr == 0 ? "Custom..." : Pointer_stringify(ptr)); var value = gametypeoptions.length; var option = document.createElement("option"); @@ -96,9 +96,17 @@ mergeInto(LibraryManager.library, { // we wouldn't get if the browser thought it was already // the selected one. But here, it's _not_ the selected // option already; its invisible evil twin is selected. + // + // (Actually, they're not _identical_ evil twins: we label + // the two slightly differently. The visible one that the + // user can select is labelled "Custom..." to hint that it + // opens a dialog box, whereas the invisible one that's + // left shown after the box closes is just "Custom", + // because that's telling you what you _have_ got + // selected.) option = document.createElement("option"); option.value = value; - option.appendChild(document.createTextNode(name)); + option.appendChild(document.createTextNode("Custom")); option.style.display = "none"; gametypeselector.appendChild(option); gametypehiddencustom = option;