zakarya/puzzles
1
0
Fork 0
mirror of git://git.tartarus.org/simon/puzzles.git synced 2025-04-21 08:01:30 -07:00
Code Issues Packages Projects Releases Wiki Activity

Loopy: fix redraw issue due to enlarged dots.

Browse Source 
dot_bbox() wasn't taking into account the new size of the dots, so
sometimes a rectangle of the grid would be redrawn without a partial
dot it should have contained, because nothing had noticed that that
dot overlapped that rectangle.

Actually I'm not sure why this bug wasn't happening _before_ I
enlarged the dots, because the previous code seemed to think dots had
a fixed size in pixels regardless of tile size, which wasn't even
true _before_ my recent commit 4de9836bc8c36cd. Perhaps it did occur,
just never while I was watching.
This commit is contained in:
Simon Tatham
2023-05-07 21:41:50 +01:00
parent d0f97926e8
commit 8237b02be4
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
loopy.c
View File

@ -3317,13 +3317,19 @@ static void dot_bbox(game_drawstate *ds, grid *g, grid_dot *d,
int *x, int *y, int *w, int *h)
{
int x1, y1;
int xmin, xmax, ymin, ymax;
grid_to_screen(ds, g, d->x, d->y, &x1, &y1);
*x = x1 - 2;
*y = y1 - 2;
*w = 5;
*h = 5;
xmin = x1 - (ds->tilesize * 5 + 63) / 64;
xmax = x1 + (ds->tilesize * 5 + 63) / 64;
ymin = y1 - (ds->tilesize * 5 + 63) / 64;
ymax = y1 + (ds->tilesize * 5 + 63) / 64;
*x = xmin;
*y = ymin;
*w = xmax - xmin + 1;
*h = ymax - ymin + 1;
}
static const int loopy_line_redraw_phases[] = {