zakarya/puzzles
1
0
Fork 0
mirror of git://git.tartarus.org/simon/puzzles.git synced 2025-04-21 08:01:30 -07:00
Code Issues Packages Projects Releases Wiki Activity

Signpost: fix an out-of-bounds read.

Browse Source 
Occurs when dragging with RMB outside the grid to unlink a path segment.

This bug was discovered using ASan.
This commit is contained in:
Evgeny Kapun
2024-11-04 14:00:29 +00:00
committed by Simon Tatham
parent ebb50f0af2
commit 8e83f39eb9
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
signpost.c
View File

@ -2069,7 +2069,7 @@ static void draw_drag_indicator(drawing *dr, game_drawstate *ds,
int fx = FROMCOORD(ui->dx), fy = FROMCOORD(ui->dy); int fx = FROMCOORD(ui->dx), fy = FROMCOORD(ui->dy);
double ang; double ang;
if (validdrag) { if (validdrag && INGRID(state, fx, fy)) {
/* If we could move here, lock the arrow to the appropriate direction. */ /* If we could move here, lock the arrow to the appropriate direction. */
dir = ui->drag_is_from ? state->dirs[ui->sy*w+ui->sx] : state->dirs[fy*w+fx]; dir = ui->drag_is_from ? state->dirs[ui->sy*w+ui->sx] : state->dirs[fy*w+fx];