zakarya/puzzles
1
0
Fork 0
mirror of git://git.tartarus.org/simon/puzzles.git synced 2025-04-21 08:01:30 -07:00
Code Issues Packages Projects Releases Wiki Activity

Correct a range check in Magnets' layout verification

Browse Source 
Squares in the grid are numbered from 0, so the upper limit check
needs to use "<=" rather than "<".  Without this, invalid descriptions
can cause a read overrun off the end of the board.
This commit is contained in:
Ben Harris
2023-03-31 20:38:31 +01:00
parent 1af1204b9c
commit 91735e5019
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
magnets.c
View File

@ -520,7 +520,7 @@ nextchar:
* (i.e. each end points to the other) */
for (idx = 0; idx < state->wh; idx++) {
if (state->common->dominoes[idx] < 0 ||
state->common->dominoes[idx] > state->wh ||
state->common->dominoes[idx] >= state->wh ||
state->common->dominoes[state->common->dominoes[idx]] != idx) {
*prob = "Domino descriptions inconsistent";
goto done;