draw_thick_line: Bound thickness by 1.0 below

A line less than 1 pixel wide may not be visible.  So if a backend
wants to draw a line whose width scaled by the window size, that line
thickness ought to be at least 1.0.

That way if the scale is small, but still big enough that there is a
straightforward interpretation of the drawing primitives which is
legible, we implement that interpretation.

If a frontend draws a narrower line, making it wider might cause
drawing anomalies, due to the line now having a bigger bounding box.
These anomalies should occur only at small scales where currently the
display is not legible, and we should fix them as we notice them.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
This commit is contained in:
Ian Jackson
2017-09-29 14:29:56 +01:00
committed by Simon Tatham
parent df3b9cb845
commit a0435df8aa
2 changed files with 5 additions and 0 deletions

View File

@ -1928,6 +1928,9 @@ Indeed, even horizontal or vertical lines may be anti-aliased.
This function may be used for both drawing and printing. This function may be used for both drawing and printing.
If the xpecified thickness is less than 1.0, 1.0 is used.
This ensures that thin lines are visible even at small scales.
\S{drawing-draw-text} \cw{draw_text()} \S{drawing-draw-text} \cw{draw_text()}
\c void draw_text(drawing *dr, int x, int y, int fonttype, \c void draw_text(drawing *dr, int x, int y, int fonttype,

View File

@ -90,6 +90,8 @@ void draw_line(drawing *dr, int x1, int y1, int x2, int y2, int colour)
void draw_thick_line(drawing *dr, float thickness, void draw_thick_line(drawing *dr, float thickness,
float x1, float y1, float x2, float y2, int colour) float x1, float y1, float x2, float y2, int colour)
{ {
if (thickness < 1.0)
thickness = 1.0;
if (dr->api->draw_thick_line) { if (dr->api->draw_thick_line) {
dr->api->draw_thick_line(dr->handle, thickness, dr->api->draw_thick_line(dr->handle, thickness,
x1, y1, x2, y2, colour); x1, y1, x2, y2, colour);