zakarya/puzzles
1
0
Fork 0
mirror of git://git.tartarus.org/simon/puzzles.git synced 2025-04-21 16:05:44 -07:00
Code Issues Packages Projects Releases Wiki Activity

Remove a redundant and also erroneous memset.

Browse Source 
(If you're going to memset a struct to 0 before filling in the fields
you care about, do use sizeof the struct rather than sizeof the
pointer; but also, if you're filling in _every_ field, there's no need
to bother anyway.)

[originally from svn r9773]
This commit is contained in:
Simon Tatham
2013-03-11 19:58:28 +00:00
parent 48f9d92f6f
commit b5756838f3
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
lightup.c
View File

@ -657,7 +657,6 @@ static void list_lights(game_state *state, int ox, int oy, int origin,
{ {
int x,y; int x,y;
memset(lld, 0, sizeof(lld));
lld->ox = lld->minx = lld->maxx = ox; lld->ox = lld->minx = lld->maxx = ox;
lld->oy = lld->miny = lld->maxy = oy; lld->oy = lld->miny = lld->maxy = oy;
lld->include_origin = origin; lld->include_origin = origin;