zakarya/puzzles
1
0
Fork 0
mirror of git://git.tartarus.org/simon/puzzles.git synced 2025-04-21 08:01:30 -07:00
Code Issues Packages Projects Releases Wiki Activity

Undead: remove an unused structure field.

Browse Source 
I noticed that state->common, which is shared between all the game
states in an undo chain, has a 'solved' flag in it. That's not right -
solvedness as a property of a particular state on the chain belongs in
the game_state itself, and having-at-one-point-been-solved-ness as a
persistent property of the whole chain belongs in the game_ui.

Fortunately, the game isn't actually doing it wrong:
state->common->solved is set once and then never read, so it must have
been left in from early abandoned code. Now removed.
This commit is contained in:
Simon Tatham
2018-11-07 19:16:00 +00:00
parent 3189fb484d
commit b732fda2cf
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
undead.c
View File

@ -225,7 +225,6 @@ struct game_common {
int *grid;
int *xinfo;
int *fixed;
int solved;
};
struct game_state {
@ -260,7 +259,6 @@ static game_state *new_state(const game_params *params) {
state->common->grid = snewn(state->common->wh, int);
state->common->xinfo = snewn(state->common->wh, int);
state->common->fixed = NULL;
state->common->solved = FALSE;
state->common->num_paths =
state->common->params.w + state->common->params.h;