zakarya/puzzles
1
0
Fork 0
mirror of git://git.tartarus.org/simon/puzzles.git synced 2025-04-21 08:01:30 -07:00
Code Issues Packages Projects Releases Wiki Activity

Flood: don't read off the end of some parameter strings

Browse Source 
This is essentially the same fix as 73c7bc090155ab8c was for Twiddle.
The new code is less clever but more correct (and more obviously
correct).  The bug could be demonstrated by using a parameter string
of "c" or "m" with an AddressSanitizer build of Flood.
This commit is contained in:
Ben Harris
2023-02-20 14:57:31 +00:00
parent 795ccf6002
commit bbe866a381
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
flood.c
View File

@ -141,13 +141,13 @@ static void decode_params(game_params *ret, char const *string)
if (*string == 'c') {
string++;
ret->colours = atoi(string);
while (string[1] && isdigit((unsigned char)string[1])) string++;
while (*string && isdigit((unsigned char)*string)) string++;
} else if (*string == 'm') {
string++;
ret->leniency = atoi(string);
while (string[1] && isdigit((unsigned char)string[1])) string++;
}
string++;
while (*string && isdigit((unsigned char)*string)) string++;
} else
string++;
}
}