zakarya/puzzles
1
0
Fork 0
mirror of git://git.tartarus.org/simon/puzzles.git synced 2025-04-21 16:05:44 -07:00
Code Issues Packages Projects Releases Wiki Activity

rect: Fix compiler errors about uninitialized use of variables

Browse Source 
error: 'r2.x' may be used uninitialized in this function

Its happening when using gcc 5.3 with musl C library. its considering
the case when case falls into default and immediately after exiting
this there is a check if (r1.h > 0 && r1.w > 0) where r1 element is
used but not assigned anything.

GCC is not noticing the control flow where the initilization will
always work due to assertion call can be a function call from libc

Signed-off-by: Khem Raj <raj.khem@gmail.com>
This commit is contained in:
Khem Raj
2015-12-30 23:53:36 +00:00
committed by Simon Tatham
parent d295a8a93c
commit ff91d2d78d
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
rect.c
View File

@ -1317,7 +1317,8 @@ static char *new_game_desc(const game_params *params_in, random_state *rs,
if (ndirs > 0) { if (ndirs > 0) {
int which, dir; int which, dir;
struct rect r1, r2; struct rect r1, r2;
memset(&r1, 0, sizeof(struct rect));
memset(&r2, 0, sizeof(struct rect));
which = random_upto(rs, ndirs); which = random_upto(rs, ndirs);
dir = dirs[which]; dir = dirs[which];