zakarya/puzzles
1
0
Fork 0
mirror of git://git.tartarus.org/simon/puzzles.git synced 2025-04-21 08:01:30 -07:00
Code Issues Packages Projects Releases Wiki Activity

Pearl: slightly better handling of clicks outside the grid

Browse Source 
In Pearl, a mouse-down outside the grid sets ui->ndragcoords to -1.
The intended effect of this is to make sure that future drags are
ignored, so you can't try to draw a line starting off the grid.
However, this also has the effect of clearing any in-progress drag.
This can happen if there's a keyboard "drag" in progress at the time.

This is arguably wrong, but much more wrong was that interpret_move
returned MOVE_UNUSED (and previously NULL) in this case.  That meant
that the display didn't get updated to show the abandonment of the
drag, or the removal of the keyboard cursor that also happened.  This
commit changes MOVE_UNUSED to MOVE_UI_UPDATE so that at least the
effect is correctly visible.
This commit is contained in:
Ben Harris
2023-06-22 23:34:48 +01:00
parent c5076be383
commit 0d005b526e
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pearl.c
View File

@ -2175,7 +2175,7 @@ static char *interpret_move(const game_state *state, game_ui *ui,
if (!INGRID(state, gx, gy)) { if (!INGRID(state, gx, gy)) {
ui->ndragcoords = -1; ui->ndragcoords = -1;
return MOVE_UNUSED; return MOVE_UI_UPDATE;
} }
ui->clickx = x; ui->clicky = y; ui->clickx = x; ui->clicky = y;