zakarya/puzzles
1
0
Fork 0
mirror of git://git.tartarus.org/simon/puzzles.git synced 2025-04-20 15:41:30 -07:00
Code Issues Packages Projects Releases Wiki Activity

Fix a compile warning on ARM.

Browse Source 
Aapo Rantalainen points out that comparing 'char c' against zero gives
rise to gcc's "comparison is always false" warning, which escalates to
an error under -Werror.

This is one of those situations where the warning is doing more harm
than good, but here's a rephrasing which casts to unsigned so that
both negative numbers and positive out-of-range ones can be caught by
the same comparison.
This commit is contained in:
Simon Tatham
2015-03-24 19:20:03 +00:00
parent 05b533d1f8
commit 195217a480
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
flood.c
View File

@ -609,7 +609,7 @@ static char *validate_desc(const game_params *params, const char *desc)
c = 10 + (c - 'A');
else
return "Bad character in grid description";
if (c < 0 || c >= params->colours)
if ((unsigned)c >= params->colours)
return "Colour out of range in grid description";
}
if (*desc != ',')