zakarya/puzzles
1
0
Fork 0
mirror of git://git.tartarus.org/simon/puzzles.git synced 2025-04-21 08:01:30 -07:00
Code Issues Packages Projects Releases Wiki Activity

Don't refresh backing store on a no-op configure event.

Browse Source 
Sometimes, we can get a "configure_area" event telling us that the
drawing area has changed size to the same size it already was. This
can happen when we change puzzle presets in a way that doesn't change
the size, and also sometimes seems to happen as a side effect of
changing the text in the status line.

In that situation, it's a waste of effort - and can cause visible
on-screen flicker - to throw away the window's backing image and
pixmap and regenerate them from scratch. So now we detect a non-resize
and avoid doing all that.

The only thing we retain unconditionally in configure_area is the
midend_force_redraw, because that's the place where a puzzle redraw is
forced when changing presets or loading a new game.
This commit is contained in:
Simon Tatham
2015-10-03 12:27:47 +01:00
parent f9027226a0
commit 8b491946ef
1 changed files with 16 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
gtk.c
View File

@ -1199,18 +1199,24 @@ static gint configure_area(GtkWidget *widget,
frontend *fe = (frontend *)data;
int x, y;
if (backing_store_ok(fe))
teardown_backing_store(fe);
x = event->width;
y = event->height;
x = fe->w = event->width;
y = fe->h = event->height;
midend_size(fe->me, &x, &y, TRUE);
fe->pw = x;
fe->ph = y;
fe->ox = (fe->w - fe->pw) / 2;
fe->oy = (fe->h - fe->ph) / 2;
if (x != fe->w || y != fe->h || !backing_store_ok(fe)) {
if (backing_store_ok(fe))
teardown_backing_store(fe);
fe->w = x;
fe->h = y;
midend_size(fe->me, &x, &y, TRUE);
fe->pw = x;
fe->ph = y;
fe->ox = (fe->w - fe->pw) / 2;
fe->oy = (fe->h - fe->ph) / 2;
setup_backing_store(fe);
}
setup_backing_store(fe);
midend_force_redraw(fe->me);
return TRUE;