zakarya/puzzles
1
0
Fork 0
mirror of git://git.tartarus.org/simon/puzzles.git synced 2025-04-20 23:51:29 -07:00
Code Issues Packages Projects Releases Wiki Activity

Fix redrawing of Undead 'done' clues after a resize.

Browse Source 
The is_hint_stale() function has the side effect of copying a path
hint's new colour-relevant information into the game_drawstate, where
draw_path_hint will then use it. But it returns TRUE early in some
situations, notably !ds->started, which can happen after the actual
game start if the window is resized and a fresh drawstate is created.

This patch, thanks to Chris Boyle, fixes it by eliminating the early
returns from is_hint_stale - the return value is unchanged, but now
the side effects happen reliably.
This commit is contained in:
Simon Tatham
2015-07-05 21:57:38 +01:00
parent f306b9db55
commit aa1a9375be
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
undead.c
View File

@ -2506,20 +2506,21 @@ static void draw_pencils(drawing *dr, game_drawstate *ds,
static int is_hint_stale(const game_drawstate *ds, int hflash,
const game_state *state, int index)
{
if (!ds->started) return TRUE;
if (ds->hflash != hflash) return TRUE;
int ret = FALSE;
if (!ds->started) ret = TRUE;
if (ds->hflash != hflash) ret = TRUE;
if (ds->hint_errors[index] != state->hint_errors[index]) {
ds->hint_errors[index] = state->hint_errors[index];
return TRUE;
ret = TRUE;
}
if (ds->hints_done[index] != state->hints_done[index]) {
ds->hints_done[index] = state->hints_done[index];
return TRUE;
ret = TRUE;
}
return FALSE;
return ret;
}
static void game_redraw(drawing *dr, game_drawstate *ds,