zakarya/puzzles
1
0
Fork 0
mirror of git://git.tartarus.org/simon/puzzles.git synced 2025-04-20 15:41:30 -07:00
Code Issues Packages Projects Releases Wiki Activity

Black Box: correct order of validation checks for "F" commands

Browse Source 
It doesn't do much good to range-check an argument after using it as
an array index.
This commit is contained in:
Ben Harris
2023-01-08 10:03:10 +00:00
parent d5b8a20def
commit c2eedeedfe
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
blackbox.c
View File

@ -1067,10 +1067,10 @@ static game_state *execute_move(const game_state *from, const char *move)
case 'F':
sscanf(move+1, "%d", &rangeno);
if (ret->exits[rangeno] != LASER_EMPTY)
goto badmove;
if (!RANGECHECK(ret, rangeno))
goto badmove;
if (ret->exits[rangeno] != LASER_EMPTY)
goto badmove;
fire_laser(ret, rangeno);
break;