Fix false-positive completion detection in X Solo.

Spotted by Michael Quevillon. After checking the set of digits
appearing in one of the two main grid diagonals, we weren't clearing
the used[] array before using it to check the same thing about the
other diagonal. So if the first diagonal we check has one of
everything, then the second will be misidentified as correct (for the
purposes of game-completion detection, although not error
highlighting) even if it doesn't have one of everything.
This commit is contained in:
Simon Tatham
2018-03-25 22:27:38 +01:00
parent 2adf0052d6
commit c6e0161dd4

2
solo.c
View File

@ -3103,6 +3103,8 @@ static int check_valid(int cr, struct block_structure *blocks,
sfree(used);
return FALSE;
}
memset(used, FALSE, cr);
for (i = 0; i < cr; i++)
if (grid[diag1(i)] > 0 && grid[diag1(i)] <= cr)
used[grid[diag1(i)]-1] = TRUE;