zakarya/puzzles
1
0
Fork 0
mirror of git://git.tartarus.org/simon/puzzles.git synced 2025-04-21 16:05:44 -07:00
Code Issues Packages Projects Releases Wiki Activity

Emscripten: change the localStorage key used for preferences.

Browse Source 
I picked pathname + "#preferences" because Ben suggested either that
or pathname + "/preferences", and I thought the former sounded neater.
But Ben now suggests that it might be better to avoid using # in the
key, just in case anyone should later want to use the whole URL
_including_ the fragment ID as the key for some other localStorage
usage - for example, autosaved progress per puzzle _instance_, keying
off the puzzle URL with a fragment ID in the game description.

So, per Ben's replacement suggestion, change the "#" to a space.
This commit is contained in:
Simon Tatham
2023-04-24 14:24:19 +01:00
parent 43db4aa38e
commit 20d424bf1b
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
emcclib.js
View File

@ -801,7 +801,7 @@ mergeInto(LibraryManager.library, {
*/ */
js_save_prefs: function(buf) { js_save_prefs: function(buf) {
var prefsdata = UTF8ToString(buf); var prefsdata = UTF8ToString(buf);
localStorage.setItem(location.pathname + "#preferences", prefsdata); localStorage.setItem(location.pathname + " preferences", prefsdata);
}, },
/* /*
@ -811,7 +811,7 @@ mergeInto(LibraryManager.library, {
* pass it back in as a string, via prefs_load_callback. * pass it back in as a string, via prefs_load_callback.
*/ */
js_load_prefs: function(me) { js_load_prefs: function(me) {
var prefsdata = localStorage.getItem(location.pathname+"#preferences"); var prefsdata = localStorage.getItem(location.pathname+" preferences");
if (prefsdata !== undefined && prefsdata !== null) { if (prefsdata !== undefined && prefsdata !== null) {
prefs_load_callback(me, prefsdata); prefs_load_callback(me, prefsdata);
} }